Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip fields that report "not supported" in nvidia-smi #4123

Merged
merged 1 commit into from
May 8, 2018

Conversation

danielnelson
Copy link
Contributor

@danielnelson danielnelson commented May 8, 2018

I do have some concern that the nvidia-smi tool may localize this message, but I don't want to get overly aggressive is skipping unknown data.

closes: #4120

cc @jackzampolin

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added the fix pr to fix corresponding bug label May 8, 2018
@danielnelson danielnelson added this to the 1.7.0 milestone May 8, 2018
@jackzampolin
Copy link
Contributor

Looks good to me! Great catch @l1b0k

@danielnelson danielnelson merged commit 2bf2b51 into master May 8, 2018
@danielnelson danielnelson deleted the nvidia-smi-not-supported-fix branch May 8, 2018 20:11
jvrahav pushed a commit to jvrahav/telegraf that referenced this pull request May 9, 2018
arkady-emelyanov pushed a commit to arkady-emelyanov/telegraf that referenced this pull request May 18, 2018
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvidia-smi plugin failed when some metric is not supported
2 participants